-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add DesiredStateChanged event filter #110
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Bob Haddleton <[email protected]>
Further testing has revealed a possible issue with Objects not getting updated properly. I'm investigating. |
@bobh66 did you find anything here? for example, if an immutable object is attempted changed, provider-kubernetes "spins" very actively trying to reconcile it :( I think this would fix that
full event (example):
in this case, the randomness is here: ... |
@bobh66 do you still want to proceed here? |
Description of your changes
Added the DesiredStateChanged EventFilter to the controller to avoid unnecessary reconciliations.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Executed this code in a development cluster doing multiple deployments.