Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename proto/v1beta1/Resource.Resource field to improve clarity #36

Open
pedjak opened this issue Sep 29, 2023 · 2 comments
Open

Rename proto/v1beta1/Resource.Resource field to improve clarity #36

pedjak opened this issue Sep 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pedjak
Copy link

pedjak commented Sep 29, 2023

There is a struct Resource containing field Resource. The doc says it is the json representation of the given resource. Could we rename the field to reflect that?
@pedjak pedjak added the enhancement New feature or request label Sep 29, 2023
@negz
Copy link
Member

negz commented Sep 30, 2023

Any suggestions on naming?

In a way I think the Resource field is accurate, it's more that the message it lives in represents not only a resource but its associated properties - e.g. connection details and readiness. So renaming the Resource message could be another option.

@pedjak
Copy link
Author

pedjak commented Oct 4, 2023

Any suggestions on naming?

Since it contains the resource content encoded in json, perhaps we can call it JSONData?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pedjak @negz