Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples-generated metadata annotations and labels API group hardcoded to upbound.io #473

Open
humoflife opened this issue Feb 28, 2025 · 0 comments
Open

examples-generated metadata annotations and labels API group hardcoded to upbound.io #473

humoflife opened this issue Feb 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@humoflife
Copy link

What happened?

When creating a provider with a specific API group, e.g. crossplane.io, upjet generates examples with metadata annotations and labels referring to upbound.io, which is hardcoded at https://github.com/crossplane/upjet/blob/72675757bb33ae6153813b0f6d1d0bf7bba9dba3/pkg/examples/example.go#L35.

Please consider using the specified API group instead of the hardcoded "upbound.io".

How can we reproduce it?

make generate
@humoflife humoflife added the bug Something isn't working label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humoflife