From 5f0a6bcaebd95beeeb8b19aace7cbc7bf4f7f3e5 Mon Sep 17 00:00:00 2001 From: Alexis Menard Date: Tue, 11 Aug 2015 14:24:38 -0400 Subject: [PATCH] Fix build on Windows when using components build. Due to some ffmpeg changes which now statically build ffmpeg onto Chromium/Crosswalk the component build was broken on Windows. It turns out that it couldn't link due to missing symbols in ffmpeg.dll (the very same we use in sysapp code). It's due to two changes in upstream : - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/467a5ef970 which now use ffmpeg.sigs to generate the exported symbols - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/59c940d188 which is a following patch after ffmpegsumo removal. The code we have in chromium-crosswalk which adds the extra symbols we use from ffmpeg needs to be adapted and the sigs file needs to be renamed. See original patch : https://github.com/crosswalk-project/chromium-crosswalk/commit/60bc4428aaa0a10a1522dbbca2796b4352d14747 --- tools/generate_stubs/{xwalk_ffmpegsumo.sigs => xwalk_ffmpeg.sigs} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tools/generate_stubs/{xwalk_ffmpegsumo.sigs => xwalk_ffmpeg.sigs} (100%) diff --git a/tools/generate_stubs/xwalk_ffmpegsumo.sigs b/tools/generate_stubs/xwalk_ffmpeg.sigs similarity index 100% rename from tools/generate_stubs/xwalk_ffmpegsumo.sigs rename to tools/generate_stubs/xwalk_ffmpeg.sigs