Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crowdin file download command ignores --no-progress option #878

Closed
PaulTaykalo opened this issue Jan 6, 2025 · 2 comments · Fixed by #880
Closed

crowdin file download command ignores --no-progress option #878

PaulTaykalo opened this issue Jan 6, 2025 · 2 comments · Fixed by #880
Assignees
@by-su
Labels
bug good first issue

Comments

@PaulTaykalo
Copy link

PaulTaykalo commented Jan 6, 2025 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.
Try to run crowdin file download with --no-progress option.
The progress still be shown

To Reproduce
Steps to reproduce the behavior:

  1. Configuration file: Irrelevant
  2. Execute CLI command: 'crowdin file download "/Example.txt' -d ./Example.txt
  3. See the progress of fetching project info

Expected behavior
No spinner/progress should be shown, when the command is running with --no-progress option

Environment:

  • OS: macOS
  • Version 14.5

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

It seems that these parameters are totally ignored and when calling FileDownloadTranslation action

crowdin-cli/src/main/java/com/crowdin/cli/commands/actions/FileDownloadTranslationAction.java

Lines 43 to 45 in a0345b8

CrowdinProjectFull project = ConsoleSpinner
.execute(out, "message.spinner.fetching_project_info", "error.collect_project_info",
false, false, client::downloadFullProject);

@by-su
Copy link
Contributor

by-su commented Jan 7, 2025

Hi, I'd like to work on this issue. Could you assign it to me ?

@zozulka
Copy link

zozulka commented Jan 7, 2025

Hi @by-su ! Will check this possibility with our team and will come back with updates!

@by-su by-su mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@by-su by-su

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: suppress progress output for crowdin file download with --no-progress by-su/crowdin-cli
4 participants
@PaulTaykalo @andrii-bodnar @zozulka @by-su