Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 build in weekly CI. #146

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Fix x86 build in weekly CI. #146

merged 8 commits into from
Feb 24, 2025

Conversation

crud89
Copy link
Owner

@crud89 crud89 commented Feb 24, 2025

Describe the pull request

This PR fixes the build failures for x86 builds in weekly CI. It introduces a helper method for safely requesting a handle address in Vulkan to fix overload and deduction issues. As a side change, it now uses the updated llvm-install action istead of running chocolatey, which should hopefully improve build times.

Checklist

  • Run static code analysis and fix potential issues it reports.
    • You can do this by building targets windows-clangcl-x64-release and windows-clangcl-x86-release.
    • Avoid using NOLINT comments; if unavoidable (e.g. for false-positives, etc.), please leave a comment within the PR body to explain it.
  • If this PR is work in progress, open it as a draft PR.
  • If required, update the .natvis file(s) of the altered projects to reflect your changes.
  • Before submitting the PR, make sure to update the .docs/release-logs/ for the next version with a summary of the changes.
    • Consider creating a draft PR to acquire it's URL.
    • If the PR addresses a bug that can be fixed without breaking API compatibility†, leave a comment so that we can target the proper branch.

† API compatibility means that code that compiles against the current version, should also compile against the next version.

@crud89 crud89 added Vulkan 🌋 The issue involves the Vulkan backend. Build 🛠 Issues that involve the build process. labels Feb 24, 2025
@crud89 crud89 added this to the Alpha #04 milestone Feb 24, 2025
@crud89 crud89 self-assigned this Feb 24, 2025
@crud89
Copy link
Owner Author

crud89 commented Feb 24, 2025

Run: checks

@crud89 crud89 marked this pull request as ready for review February 24, 2025 12:06
@crud89 crud89 merged commit 2380075 into main Feb 24, 2025
2 checks passed
@crud89 crud89 deleted the vs_17_13_fixes branch February 24, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build 🛠 Issues that involve the build process. Vulkan 🌋 The issue involves the Vulkan backend.
Projects
Status: v0.4.1
Development

Successfully merging this pull request may close these issues.

1 participant