Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #15

Open
crutonjohn opened this issue Jun 18, 2024 · 1 comment · May be fixed by #23
Open

Memory Leak #15

crutonjohn opened this issue Jun 18, 2024 · 1 comment · May be fixed by #23

Comments

@crutonjohn
Copy link
Owner

There is a memory leak somewhere that I need to track down. It presents after running for a while if you don't have resource limits applied to the pod.

external-dns-opnsense-7b47b8c54c-d8b77         1m           1189Mi

definitely don't need to be using over a gig of memory 😅
@crutonjohn
Copy link
Owner Author

i think it could be in this function:

https://github.com/crutonjohn/external-dns-opnsense-webhook/blob/main/internal/opnsense-unbound/client.go#L183-L202

crutonjohn added a commit that referenced this issue Oct 15, 2024
@crutonjohn
fix(dorequest): properly close client body
864744b 
this prevents us from storing responses infinitely, and should resolve our memory leak

fix #15
@crutonjohn crutonjohn linked a pull request Oct 15, 2024 that will close this issue
Open
crutonjohn added a commit that referenced this issue Oct 15, 2024
@crutonjohn
fix(dorequest): try DRY-ing out close response
50f2979 
#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dorequest): properly close client body crutonjohn/external-dns-opnsense-webhook
1 participant
@crutonjohn