-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete old classes and replace their use with new math features #32
Comments
|
Please don't make |
The two users just instantiate a random polynomial of non-zero coefficients with specific degree and then set the 0-th coefficient to a specific value. I certainly can have that done manually. |
I would ike to move Also, |
@feidens am I not seeing something from the good ol' project group days here? 🤔 |
So seems like the Waters Hash we implement in this case is the one from page 26 in this paper. Since the waters hash is only used in a couple of our predicate encryption schemes, it seems sensible to move it to the The |
|
Okay, I moved The latter is only used for |
All the issues except refactoring |
We want to get rid of
PrimeFieldPolynomial
(replace withPolynomialRing
and its elements) andSecureRandomGenerator
(automatically becomes unused after removingPrimeFieldPolynomial
)LagrangeUtil
feels like it should be replaced by use ofPolynomialRing
, too. Maybe have to look closer into its uses (but I cannot imagine its uses cannot be replaced byde.upb.crypto.math.structures.polynomial.PolynomialRing#getPoly(Map<? extends RingElement,? extends RingElement>)
).de/upb/crypto/craco/interaction
(can just be deleted, has no use)de.upb.crypto.craco.abe.interfaces.Triple
can go.de.upb.crypto.craco.kem.asym.elgamal.ElgamalKEM#computeNonceHash
can essentially be replaced byHashIntoZn
(though this has less of a priority since it's an implementation detail and does not affect API)The text was updated successfully, but these errors were encountered: