-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: sdk 47 is not integrated #1023
Conversation
Signed-off-by: yihuang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 32.91% 32.95% +0.03%
==========================================
Files 130 128 -2
Lines 20161 20001 -160
==========================================
- Hits 6637 6592 -45
+ Misses 12461 12353 -108
+ Partials 1063 1056 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]>
2dcfd5d
Solution: - revert the package name change introduced in crypto-org-chain#1023. - don't remember why we have to change it there, but it seems not nesserary, revert it to keep it backward compatible.
Solution: - revert the package name change introduced in crypto-org-chain#1023. - don't remember why we have to change it there, but it seems not nesserary, revert it to keep it backward compatible. Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> match protobuf package name with directory structure fix test
Solution: - revert the package name change introduced in #1023. - don't remember why we have to change it there, but it seems not nesserary, revert it to keep it backward compatible. Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> match protobuf package name with directory structure fix test
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)