-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Crypto.org Chain is renamed to Cronos POS Chain #1029
Conversation
Solution: Rename all occurences to updated values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 33.10% 33.08% -0.02%
==========================================
Files 126 126
Lines 20041 20041
==========================================
- Hits 6634 6631 -3
- Misses 12345 12349 +4
+ Partials 1062 1061 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
is it still a draft ? @calvinaco |
I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon. |
hi, how can we help you? which application do you mean? |
Salutations and hello. Back in 2022, many changes to the cdc.app as a result of either hacking or change in policy caused an error in a transaction that absolutely SHOULD have never happened. I had transacted in various crypto. Mostly xlm, but never making the mistake of sending coins via the wrong network. I digress, as i stated I had previously transacted in USDC and on this particular day, after an update to the platform. ERC-20 was no longer the DEFAULT setting for sending USDC. Instead CRONOS network was the default setting. I sent a transfer of 500 usdc via cronos. It still sits here to this day and im positive that it can be recovered before waiting for CRO to be offered at kraken exchange. Below is the adresss. If nothing else. Explain to me how 5 other tokens have managed to find their way to this address on the cronos network. I understand the concept of TVL. But this was a very expensive lesson that could have been avoided. I have been waiting for a response from CDC for issues as benign as referral bonuses for over 2 weeks. There has never been an intelligent explanation furnished from CDC as to why this happened. Makes me laugh, given that story where by they sent 25 million dollars in eth to the wrong address. Yet somehow they were able to reverse this transaction. I understand the concept (to a degree) of custodial wallets. Kraken at this time does not offer a custodial wallet, still has always rubbed me the wrong way that it was not soley user error. There never should have even been the option to send an ERC -20 token via CRONOs. Like i stated i had transacted not only in USDC but several other currencies and never had an issue until several changes at the time on CDC platform with respect to UI layout, and Whitelisted addresses. Thank you for coming to my ted talk. If nothing else i hope to understand how the additional tokens came to find themselves parked in the same location as my 500.20 usdc. 0xaF54ce06bc1384158b016B2E33cc3A452D1862fd |
Crypto.com app crypto.com defi. Takes 1 min or less to receive xlm more than 45 to send. I would definitely love to understand what the cronos network adds to utility. Should try the exchange just to short in volatility but lol kraken pro exists. Coinbase pro exist. The only way this company moves up in the food chain is by way of other companies disappearing entirely. Idk how cdc or cro ever gets compared to bnb. Market cap and volume are real things! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by: #1071 |
Solution: Rename all occurrences to updated values
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)