Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Crypto.org Chain is renamed to Cronos POS Chain #1029

Closed
wants to merge 4 commits into from

Conversation

calvinaco
Copy link
Contributor

@calvinaco calvinaco commented Feb 6, 2024

Solution: Rename all occurrences to updated values

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@calvinaco calvinaco changed the title Rename to cronos pos Problem: Crypto.org Chain is renamed to Cronos POS Chain Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2d5ed7) 33.10% compared to head (15de945) 33.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   33.10%   33.08%   -0.02%     
==========================================
  Files         126      126              
  Lines       20041    20041              
==========================================
- Hits         6634     6631       -3     
- Misses      12345    12349       +4     
+ Partials     1062     1061       -1     
Flag Coverage Δ
integration_tests 20.71% <100.00%> (ø)
integration_tests_byzantine 9.66% <100.00%> (ø)
integration_tests_gov 10.03% <100.00%> (ø)
integration_tests_grpc 10.01% <100.00%> (ø)
integration_tests_ibc 24.81% <100.00%> (-0.02%) ⬇️
integration_tests_ledger 9.90% <100.00%> (ø)
integration_tests_slow 9.90% <100.00%> (ø)
integration_tests_solomachine 9.69% <100.00%> (ø)
integration_tests_upgrade 10.01% <100.00%> (ø)
unit_tests 10.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-nguy
Copy link

is it still a draft ? @calvinaco

@infinitebreakfast
Copy link

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

@yihuang
Copy link
Collaborator

yihuang commented Feb 28, 2024

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

hi, how can we help you? which application do you mean?

@infinitebreakfast
Copy link

Salutations and hello. Back in 2022, many changes to the cdc.app as a result of either hacking or change in policy caused an error in a transaction that absolutely SHOULD have never happened. I had transacted in various crypto. Mostly xlm, but never making the mistake of sending coins via the wrong network. I digress, as i stated I had previously transacted in USDC and on this particular day, after an update to the platform. ERC-20 was no longer the DEFAULT setting for sending USDC. Instead CRONOS network was the default setting. I sent a transfer of 500 usdc via cronos. It still sits here to this day and im positive that it can be recovered before waiting for CRO to be offered at kraken exchange.

Below is the adresss.

If nothing else. Explain to me how 5 other tokens have managed to find their way to this address on the cronos network. I understand the concept of TVL. But this was a very expensive lesson that could have been avoided. I have been waiting for a response from CDC for issues as benign as referral bonuses for over 2 weeks. There has never been an intelligent explanation furnished from CDC as to why this happened. Makes me laugh, given that story where by they sent 25 million dollars in eth to the wrong address. Yet somehow they were able to reverse this transaction.

I understand the concept (to a degree) of custodial wallets. Kraken at this time does not offer a custodial wallet, still has always rubbed me the wrong way that it was not soley user error. There never should have even been the option to send an ERC -20 token via CRONOs. Like i stated i had transacted not only in USDC but several other currencies and never had an issue until several changes at the time on CDC platform with respect to UI layout, and Whitelisted addresses.

Thank you for coming to my ted talk.

If nothing else i hope to understand how the additional tokens came to find themselves parked in the same location as my 500.20 usdc.

0xaF54ce06bc1384158b016B2E33cc3A452D1862fd

@infinitebreakfast
Copy link

B08F0F8A-945E-46DE-ACD3-E1A55E077B84
6C9DCF43-62A2-46A3-A8F7-919BCB01237E

I have proof. Of the changes they made to the ui.

@infinitebreakfast
Copy link

I just want to know how I ever sent usdc via the cronos network and not erc 20. I will never understand how so much good work goes into this network when the app is still written in crayon.

hi, how can we help you? which application do you mean?

Crypto.com app crypto.com defi. Takes 1 min or less to receive xlm more than 45 to send. I would definitely love to understand what the cronos network adds to utility. Should try the exchange just to short in volatility but lol kraken pro exists. Coinbase pro exist. The only way this company moves up in the food chain is by way of other companies disappearing entirely. Idk how cdc or cro ever gets compared to bnb. Market cap and volume are real things!

Copy link

@Boyka0805 Boyka0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Boyka0805 Boyka0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Boyka0805 Boyka0805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang
Copy link
Collaborator

yihuang commented Jul 31, 2024

fixed by: #1071

@yihuang yihuang closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants