Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fail to build in recent nixpkgs #1031

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 16, 2024

Solution:

  • fix the expression

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner February 16, 2024 07:10
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de1508e) 30.08% compared to head (04a0e88) 30.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1031   +/-   ##
=======================================
  Coverage   30.08%   30.08%           
=======================================
  Files         125      125           
  Lines       20039    20039           
=======================================
  Hits         6028     6028           
  Misses      12965    12965           
  Partials     1046     1046           
Flag Coverage Δ
integration_tests 20.71% <ø> (ø)
integration_tests_byzantine 9.66% <ø> (ø)
integration_tests_gov 10.03% <ø> (ø)
integration_tests_grpc 10.01% <ø> (ø)
integration_tests_ibc 24.81% <ø> (ø)
integration_tests_ledger 9.90% <ø> (ø)
integration_tests_slow 9.90% <ø> (ø)
integration_tests_solomachine 9.69% <ø> (ø)
integration_tests_upgrade 10.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yihuang yihuang requested a review from mmsqe February 16, 2024 07:14
default.nix Outdated Show resolved Hide resolved
Solution:
- fix the expression

Update default.nix

Signed-off-by: yihuang <[email protected]>

fix lint
@yihuang yihuang added this pull request to the merge queue Feb 16, 2024
Merged via the queue into crypto-org-chain:master with commit 04e8e09 Feb 16, 2024
31 of 32 checks passed
@yihuang yihuang deleted the fix-nix branch February 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants