Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1063

Closed
wants to merge 2 commits into from
Closed

Conversation

pudongair
Copy link

@pudongair pudongair commented Jul 19, 2024

fix some comments

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@pudongair pudongair requested a review from a team as a code owner July 19, 2024 12:27
@yihuang
Copy link
Collaborator

yihuang commented Jul 20, 2024

can you sign the commit @pudongair

Signed-off-by: pudongair <[email protected]>
@pudongair
Copy link
Author

can you sign the commit @pudongair

Of course. Signed.

Please review again.

@yihuang yihuang enabled auto-merge July 22, 2024 05:04
@yihuang
Copy link
Collaborator

yihuang commented Aug 7, 2024

seems has fixed by other PR.

@yihuang yihuang closed this Aug 7, 2024
auto-merge was automatically disabled August 7, 2024 06:46

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants