-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: persist-credentials might leak github token unintentionally #1090
Merged
mmsqe
merged 3 commits into
crypto-org-chain:master
from
yihuang:no-persist-credentials
Oct 30, 2024
Merged
Problem: persist-credentials might leak github token unintentionally #1090
mmsqe
merged 3 commits into
crypto-org-chain:master
from
yihuang:no-persist-credentials
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - try persist-credentials: false
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
- Coverage 34.23% 31.72% -2.51%
==========================================
Files 93 93
Lines 14151 17020 +2869
==========================================
+ Hits 4844 5400 +556
- Misses 8365 10678 +2313
Partials 942 942
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
13 tasks
Signed-off-by: yihuang <[email protected]>
mmsqe
approved these changes
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2024
Merged
via the queue into
crypto-org-chain:master
with commit Oct 30, 2024
c23a527
29 of 32 checks passed
mmsqe
added a commit
to mmsqe/chain-main
that referenced
this pull request
Dec 18, 2024
…rypto-org-chain#1090) * Problem: persist-credentials might leak github token unintentionally Solution: - try persist-credentials: false * refresh --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)