Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Unlock Canceled” showing when trying to unlock vault on SMB share ("No valid file provider found with identifier 'com.apple.SMBClient-Provider.FileProvider'.") #262

Open
2 tasks done
ericswpark opened this issue Sep 18, 2022 · 6 comments
Labels
state:has-workaround There is a known workaround for the described problem storage:other-file-provider type:upstream-bug Something isn't working in upstream

Comments

@ericswpark
Copy link

Please agree to the following

Summary

Cryptomator sometimes fails to open vaults on SMB shares, through the iOS file provider

System Setup

  • iOS: 16.0 (20A362)
  • Cryptomator: Version 2.4.1 (997)

Cloud Type

Other File Provider

Steps to Reproduce

  1. Go to “Browse” tab in Files app
  2. Select Cryptomator vault located on SMB share
  3. Unlock (with Face ID)

Expected Behavior

The vault unlocks

Actual Behavior

The vault fails to unlock and displays:

“Unlock Canceled”
“Unlock via Face ID was not successful. Please try again.”

Attempting to unlock again brings up the Cryptomator password input prompt. Trying to unlock via Face ID does nothing and the prompt stays there. Attempting to unlock with the password shows the following error:

“Error”
“No valid file provider found with identifier 'com.apple.SMBClient-Provider.FileProvider'”

Reproducibility

Intermittent

Relevant Log Output

No response

Anything else?

Screen after initial unlock attempt:
IMG_3450

Face ID unlock on this prompt does absolutely nothing (Face ID auth succeeds but nothing happens after):
IMG_3451

Typing in the password results in the following error message:
IMG_3452

@ericswpark ericswpark added the type:bug Something isn't working label Sep 18, 2022
@ericswpark
Copy link
Author

Honestly, given how many layers Cryptomator has to go through with the SMB file provider (like, does it automatically remount the SMB share if it has disconnected due to network problems? What if it can’t reach the share at all because the VPN is down? Etc etc) I think it would be really cool to add a SMB option in Cryptomator so it can handle mounting and all that every time the vault is opened. Hopefully by removing all the intermediate layers this unlock process is less prone to errors.

It doesn’t help that the iOS SMB implementation is horribly buggy (for example, large file copying still hangs the Files app when trying to paste the actual file).

@ericswpark
Copy link
Author

Relevant log:

2022/10/01 08:49:52:716  Error: Error Domain=NSFileProviderErrorDomain Code=-2001 "No valid file provider found with identifier ‘com.apple.SMBClientProvider.FileProvider‘." UserInfo={NSLocalizedDescription=No valid file provider found with identifier ‘com.apple.SMBClientProvider.FileProvider‘.}

@tobihagemann
Copy link
Member

I suppose this is somewhat related to #265? I'm unable to reproduce this issue, it may be specific to the SMB share.

When using the "Other File Provider" option, Cryptomator is not doing anything fancy with it. I guess the complexity lies within the Files app. Cryptomator just tries to access the vault at the saved location. If it's missing, you have to "fix" it in the Files app.

@ericswpark
Copy link
Author

@tobihagemann the problem is the error shows even when the underlying SMB share is already mounted.

@ericswpark
Copy link
Author

I've found a good way to reproduce this bug, but it shows a different error message now, so I'll create another issue for this.

@tobihagemann tobihagemann added storage:other-file-provider type:upstream-bug Something isn't working in upstream and removed type:bug Something isn't working labels Jan 25, 2023
@tobihagemann
Copy link
Member

tobihagemann commented Jan 25, 2023

I'm re-opening this issue because it's more likely what users will encounter, especially the error message you've posted. But I'm marking this as an upstream bug for now because the SMB client randomly disappears.

Workaround

As stated in #294, you have to re-add the vault.

@tobihagemann tobihagemann reopened this Jan 25, 2023
@tobihagemann tobihagemann added the state:has-workaround There is a known workaround for the described problem label Jan 25, 2023
@tobihagemann tobihagemann changed the title “Unlock Canceled” showing when trying to unlock vault on SMB share “Unlock Canceled” showing when trying to unlock vault on SMB share ("No valid file provider found with identifier 'com.apple.SMBClient-Provider.FileProvider'.") Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:has-workaround There is a known workaround for the described problem storage:other-file-provider type:upstream-bug Something isn't working in upstream
Projects
None yet
Development

No branches or pull requests

2 participants