Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip vault detection so that subfolders of a vault can be navigated to #36

Open
ghost opened this issue Jun 30, 2021 · 7 comments
Labels
type:enhancement Improvements on an existing feature

Comments

@ghost
Copy link

ghost commented Jun 30, 2021

Basically this version ignores anything after dav, for example, I have a vault at example.com/dav/SS1, which I can’t access because Cryptomator will discover one key at example.com/dav directly and “ask” if I want to open this vault, but not give me an option to decline and choose another key for a vault not located in the /dav path.

@tobihagemann tobihagemann added the type:enhancement Improvements on an existing feature label Jun 30, 2021
@tobihagemann
Copy link
Member

Thank you for your feedback! Just to be sure if it's a bug or if this actually a request for an enhancement: Is this folder (root folder, "/dav") also a vault? Or was it falsely detected as a vault?

At some point, we'll add an option to skip this detection so that you can navigate to subfolders.

Since you're using WebDAV, a workaround could be to add another WebDAV connection that already contains the "SS1" subpath. But I'm not sure how Cryptomator currently behaves on vaults in "root" in general. We'll look into it!

@ghost
Copy link
Author

ghost commented Jun 30, 2021

Hey there, even if I create a new WebDAV connection with the subpath, it’s still getting ignored because there is a vault key in /dav. It seems like as long as there is a vault key in the path before you bypass that.

Theres definitely a vault there at the main root, but not sure how I’d get to the vault in the subpath beyond just renaming the vault key in the main path long enough to match the key in the app and then revert the name?

@tobihagemann tobihagemann changed the title Cryptomator Ignores anything after DAV Add option to skip vault detection so that subfolders of a vault can be navigated to Jul 1, 2021
@ghost
Copy link
Author

ghost commented Jul 2, 2021

Just a follow up on this. How is Cryptomator automatically finding the master key in this new version? I tried renaming the masterkey just so I could just then specify the location, but the app still finds the master key even if I rename the file.

If I remove the key from the cloud long enough to get into the sub folder would that affect future functionality in any way?

@phil1995
Copy link
Collaborator

phil1995 commented Jul 2, 2021

We detect a legacy Vault (Vault Format 6 & 7) by checking the existence of a masterkey.cryptomator file and a d folder in the current folder.
Starting with Vault Format 8, instead of checking the existence of a masterkey.cryptomator file, the existence of a vault.cryptomator file is checked.

The current vault detection logic can be viewed in the VaultDetector.

@ghost
Copy link
Author

ghost commented Jul 7, 2021

We detect a legacy Vault (Vault Format 6 & 7) by checking the existence of a masterkey.cryptomator file and a d folder in the current folder.
Starting with Vault Format 8, instead of checking the existence of a masterkey.cryptomator file, the existence of a vault.cryptomator file is checked.

The current vault detection logic can be viewed in the VaultDetector.

Thanks for pointing me in that direction! I’ve been using Cryptomator on iOS for years now and haven’t really used it on my MacBook, opened your Cryptomator on Mac yesterday and shocked to see 7 is already legacy hahaha. Most of my vaults are 6.

So just one more question. I’m in the process of migrating a huge amount of data in the vault to the new version and as soon as it started, on iOS the vault is showing as zero files, but in WebDAV they are all still there. Is that because the vault version is in the progress or renaming the files and you can’t see that until it’s completed?

@overheadhunter
Copy link
Member

I’m in the process of migrating a huge amount of data in the vault to the new version and as soon as it started, on iOS the vault is showing as zero files, but in WebDAV they are all still there. Is that because the vault version is in the progress or renaming the files and you can’t see that until it’s completed?

During migration you should not access the vault from any device. I believe what you're seeing here is the iOS app still assuming the legacy format (it has now clue you're already migrating). The updated masterkey.cryptomator and vault.cryptomator with the new vault format are only written at the end of a successful migration.

@ghost
Copy link
Author

ghost commented Jul 21, 2021

I’m in the process of migrating a huge amount of data in the vault to the new version and as soon as it started, on iOS the vault is showing as zero files, but in WebDAV they are all still there. Is that because the vault version is in the progress or renaming the files and you can’t see that until it’s completed?

During migration you should not access the vault from any device. I believe what you're seeing here is the iOS app still assuming the legacy format (it has now clue you're already migrating). The updated masterkey.cryptomator and vault.cryptomator with the new vault format are only written at the end of a successful migration.

Thanks for advising about that, totally left the vault alone while completing the migration process at that point and it completed successfully.

Luckily the main vault at “/“ for me didn’t contain anything other then a single file, so I went ahead and deleted the vault and am able to, as of Beta 2, just put in the /dav/ path and then choose which vault to open since there isn’t a vault directly in that pathway to automatically open. Worked great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements on an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants