Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait methods are not moved by bundling #1068

Closed
maximebuyse opened this issue Oct 29, 2024 · 1 comment · Fixed by #1075
Closed

Trait methods are not moved by bundling #1068

maximebuyse opened this issue Oct 29, 2024 · 1 comment · Fixed by #1075
Labels
bug Something isn't working engine Issue in the engine keep-open

Comments

@maximebuyse
Copy link
Contributor 

pub mod main {
    impl Tr for nested::St {
        fn f(self) {}
    }
    pub trait Tr {
        fn f(self);
    }
    
    pub mod nested {
        use super::Tr;
        pub struct St {}
        fn g(x: St) {
            x.f()
        }
    }
}

Open this code snippet in the playground

Here main and nested are bundled together but x.f() in g is translated to Main.f_f instead of just f_f because we don't do the renaming of trait methods.
@maximebuyse maximebuyse added bug Something isn't working engine Issue in the engine labels Oct 29, 2024
@W95Psp W95Psp mentioned this issue Oct 30, 2024
Closed
@maximebuyse maximebuyse mentioned this issue Oct 30, 2024
Merged
@maximebuyse maximebuyse mentioned this issue Nov 25, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 2, 2025
@maximebuyse maximebuyse marked this as a duplicate of #1203 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working engine Issue in the engine keep-open
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move trait methods in cyclic dependencies bundling. cryspen/hax
2 participants
@franziskuskiefer @maximebuyse