Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Init-Absorb-Squeeze* API in ML-KEM #220

Merged
merged 49 commits into from
Mar 13, 2024
Merged

Use Init-Absorb-Squeeze* API in ML-KEM #220

merged 49 commits into from
Mar 13, 2024

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Mar 12, 2024 •
edited
Loading

This replaces #211 to avoid unreachable code and panics in the extracted C code.

See cryspen/hacl-packages#453 for the corresponding C code.

karthikbhargavan and others added 30 commits February 20, 2024 20:46
@karthikbhargavan
enabling the incremental (nblocks) API for Shake128 (scalar) in Kyber
d80f9ea
@karthikbhargavan
trying to extract c
2e73fbb
@franziskuskiefer
sort imports to work with kyber-crate.sh
b6f21bc
@karthikbhargavan
eurydice initialization experiments
635439b
@karthikbhargavan
added SIMD - wip - and passing hax
26aaa66
@karthikbhargavan
made sha3 internal state abstract
2a2bf36
@franziskuskiefer @karthikbhargavan
Updated ml-kem C extraction (#208)
eee97d8 
* add a dockerfile for running extraction
* remove a panic in C
@karthikbhargavan
enabling the incremental (nblocks) API for Shake128 (scalar) in Kyber
9c6985b
@franziskuskiefer @karthikbhargavan
sort imports to work with kyber-crate.sh
652f579
@karthikbhargavan
added SIMD - wip - and passing hax
5cf2b9d
@karthikbhargavan
hand edits to work around hax bug
511c50c
@karthikbhargavan
linux testing
b56defa
@karthikbhargavan
aligned malloc and initialization
4acdf81
@karthikbhargavan
tested on mac
7dd3040
@karthikbhargavan
fix matching on K for hax
8b45a5f
@karthikbhargavan
eurydice
f96d03d
@franziskuskiefer
fixup kyber-crate.sh
7b77f63
@karthikbhargavan
fixes for avx2/linux
0dc5d74
@karthikbhargavan
Merge branch 'karthik/kyber_shake128_squeeze_nblocks' of github.com:c…
7d4613d 
…ryspen/libcrux into karthik/kyber_shake128_squeeze_nblocks
@karthikbhargavan
merged
e3361fa
@karthikbhargavan
rust format
9983cc2
@karthikbhargavan
merged main
d825ca1
@karthikbhargavan
new patches
c1f2058
@karthikbhargavan
improved C code generation by simplifying match in hash-functions
fa602a6
@karthikbhargavan
recreated patches
1c53421
@karthikbhargavan
rust format
1aea834
@karthikbhargavan
undo accidental commit gcp -> cp
d73de68
@karthikbhargavan
updated extraction
fa83765
@karthikbhargavan
updated code to free SHAKE state, avoiding memory leaks in C
7fc6a4c
@karthikbhargavan
rust format
19bf8ae
@franziskuskiefer franziskuskiefer linked an issue Mar 12, 2024 that may be closed by this pull request
Remove panics from Kyber C code #203
Closed
@franziskuskiefer franziskuskiefer mentioned this pull request Mar 13, 2024
Merged
karthikbhargavan
karthikbhargavan approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on all my machines.
Thanks!

@franziskuskiefer franziskuskiefer merged commit 700700f into main Mar 13, 2024
15 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/shakeit_kyber branch March 13, 2024 18:44
@franziskuskiefer franziskuskiefer mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove panics from Kyber C code
2 participants
@franziskuskiefer @karthikbhargavan