ML-DSA 44 instantiations and multiplexing #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add build.rs for feature detection - add instantiations for 44 - add neon sha3
keks
reviewed
Aug 22, 2024
There was a problem hiding this comment.
So far I only have pretty high level comments, as this code is pretty dense with meta programming and I always find it difficult to get into. I do have two style questions. It seems like the tests are still failing, so maybe this isn't quite ready yet anyway?
franziskuskiefer
force-pushed
the
franziskus/ml-dsa-boilerplate
branch
from
f3e2120
to
4dccc28
Compare
jschneider-bensch
approved these changes
Sep 9, 2024
Co-authored-by: Jonas Schneider-Bensch <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #275