From 234be4fdabaa78907f848f6c32fecc9c46ac5ff7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= Date: Thu, 11 Jan 2024 16:20:46 -0300 Subject: [PATCH] ci: re-enable testing on Windows with Python 3.12 --- .github/workflows/ci.yml | 3 --- setup.py | 4 +++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 17e6c43a..59362064 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,9 +36,6 @@ jobs: # brownie does not install correctly with Python 3.12 - python: 3.12 type: brownie - # TODO: review failure executing npx on Windows - - os: windows-2022 - python: 3.12 steps: - uses: actions/checkout@v4 - name: Set up shell diff --git a/setup.py b/setup.py index fe021686..019442f6 100644 --- a/setup.py +++ b/setup.py @@ -13,7 +13,9 @@ author="Trail of Bits", version="0.3.4", packages=find_packages(), - python_requires=">=3.8", + # Python 3.12.0 on Windows suffers from https://github.com/python/cpython/issues/109590 + # breaking some of our integrations. The issue is fixed in 3.12.1 + python_requires=">=3.8,!=3.12.0", install_requires=["pycryptodome>=3.4.6", "cbor2", "solc-select>=v1.0.4", "toml>=0.10.2"], extras_require={ "test": [