Skip to content

Commit b348623

Browse files
committed
Remove included makefiles from all demo Makefiles
This change consolidates build rules into each Makefile so that none of them depend on external included makefiles. This simplifies the build process and reduces inter-file dependencies. Signed-off-by: Cosmin-Andrei Iacobai <[email protected]>
1 parent efe7d8b commit b348623

File tree

48 files changed

+252
-635
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+252
-635
lines changed

chapters/app-interact/overview/guides/demo/Makefile

-36
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,43 @@
11
BINARIES = send_receive_pipe reader writer \
2-
send_fifo receive_fifo \
3-
send_unix_socket receive_unix_socket \
4-
send_net_dgram_socket receive_net_dgram_socket \
5-
send_net_stream_socket receive_net_stream_socket
2+
send_fifo receive_fifo \
3+
send_unix_socket receive_unix_socket \
4+
send_net_dgram_socket receive_net_dgram_socket \
5+
send_net_stream_socket receive_net_stream_socket
66

7-
include makefiles/multiple.mk
7+
CC = gcc
8+
MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
9+
INCLUDES_DIR := $(MAKEFILE_DIR)utils
10+
LOGGER_DIR := $(INCLUDES_DIR)/log
11+
SOCK_DIR := $(INCLUDES_DIR)/sock
812

9-
utils/sock/sock_util.o: utils/sock/sock_util.c
13+
CPPFLAGS += -I$(INCLUDES_DIR)
14+
CFLAGS += -g -Wall -Wextra
15+
LDFLAGS += -z lazy
1016

11-
send_net_stream_socket: utils/sock/sock_util.o
17+
# Object Files
18+
LOGGER_OBJ = $(LOGGER_DIR)/log.o
19+
SOCK_OBJ = $(SOCK_DIR)/sock_util.o
1220

13-
receive_net_stream_socket: utils/sock/sock_util.o
21+
SRCS = $(wildcard *.c)
22+
OBJS = $(SRCS:.c=.o)
1423

15-
clean::
16-
-rm -f socket_channel
17-
-rm -f fifo_channel
24+
# Build All Binaries
25+
all: $(BINARIES)
26+
27+
# Rule to Build Each Binary
28+
%: %.c $(LOGGER_OBJ) $(SOCK_OBJ)
29+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
30+
31+
# Rule for Logger Object
32+
$(LOGGER_OBJ): $(LOGGER_DIR)/log.c $(LOGGER_DIR)/log.h
33+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
34+
35+
# Rule for Socket Object
36+
$(SOCK_OBJ): $(SOCK_DIR)/sock_util.c $(SOCK_DIR)/sock_util.h
37+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
38+
39+
# Clean Rule
40+
clean:
41+
-rm -f $(BINARIES) $(OBJS) $(LOGGER_OBJ) $(SOCK_OBJ)
42+
43+
.PHONY: all clean

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/defs.mk

-13
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/linux.mk

-16
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/linux/d/defs.mk

-3
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/multiple.mk

-12
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/single.mk

-13
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/makefiles/slides.mk

-33
This file was deleted.

chapters/app-interact/overview/guides/demo/comm-channels/utils/sock/sock_util.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
#include <unistd.h>
1919
#include <fcntl.h>
2020

21-
#include "utils/utils.h"
22-
#include "utils/log/log.h"
23-
#include "utils/sock/sock_util.h"
21+
#include "../utils.h"
22+
#include "../log/log.h"
23+
#include "sock_util.h"
2424

2525
/*
2626
* Connect to a TCP server identified by name (DNS name or dotted decimal
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,50 @@
1-
BINARIES = server mt_server mp_server mt_pool_server mp_pool_server mp_pool_server_works
1+
BINARIES = server mt_server mp_server mt_pool_server mp_pool_server_works
22

3-
include makefiles/multiple.mk
3+
CC = gcc
4+
MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
5+
INCLUDES_DIR := $(MAKEFILE_DIR)utils
6+
LOGGER_DIR := $(INCLUDES_DIR)/log
7+
SOCK_DIR := $(INCLUDES_DIR)/sock
48

5-
server: server.o connection.o utils/sock/sock_util.o
9+
CPPFLAGS += -I$(INCLUDES_DIR)
10+
CFLAGS += -g -Wall -Wextra
11+
LDFLAGS += -z lazy
612

7-
mt_server: mt_server.o connection.o utils/sock/sock_util.o
8-
$(CC) -o $@ $^ -lpthread
13+
LOGGER_OBJ = $(LOGGER_DIR)/log.o
14+
SOCK_OBJ = $(SOCK_DIR)/sock_util.o
15+
CONNECTIONS_OBJ = connection.o
16+
TASK_OBJ = task.o
917

10-
mp_server: mp_server.o connection.o utils/sock/sock_util.o
18+
all: $(BINARIES)
1119

12-
mt_pool_server: mt_pool_server.o task.o connection.o utils/sock/sock_util.o
13-
$(CC) -o $@ $^ -lpthread
20+
server: server.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ)
21+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
1422

15-
mp_pool_server: mp_pool_server.o task.o connection.o utils/sock/sock_util.o
16-
$(CC) -o $@ $^ -lpthread
23+
mt_server: mt_server.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ)
24+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
1725

18-
mp_pool_server_works: mp_pool_server_works.o connection.o utils/sock/sock_util.o
26+
mp_server: mp_server.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ)
27+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
1928

20-
server.o: connection.h
29+
mt_pool_server: mt_pool_server.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ) $(TASK_OBJ)
30+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
2131

22-
mt_server.o: connection.h
32+
mp_pool_server_works: mp_pool_server_works.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ) $(TASK_OBJ)
33+
$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ $^ $(LDFLAGS)
2334

24-
mp_server.o: connection.h
35+
$(LOGGER_OBJ): $(LOGGER_DIR)/log.c $(LOGGER_DIR)/log.h
36+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
2537

26-
mt_pool_server.o: task.h connection.h
38+
$(SOCK_OBJ): $(SOCK_DIR)/sock_util.c $(SOCK_DIR)/sock_util.h
39+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
2740

28-
mp_pool_server.o: task.h connection.h
41+
$(CONNECTIONS_OBJ): connection.c connection.h
42+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
2943

30-
mp_pool_server_works.o: connection.h
44+
$(TASK_OBJ): task.c task.h
45+
$(CC) $(CPPFLAGS) $(CFLAGS) -c $< -o $@
3146

32-
connection.o: connection.h
47+
clean:
48+
rm -f $(BINARIES) *.o $(LOGGER_OBJ) $(SOCK_OBJ) $(CONNECTIONS_OBJ) $(TASK_OBJ)
3349

34-
task.o: task.h
35-
36-
utils/sock/sock_util.o: utils/sock/sock_util.c utils/sock/sock_util.h
37-
38-
clean::
39-
-rm -f utils/sock/sock_util.o
50+
.PHONY: all clean

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/defs.mk

-13
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/linux.mk

-16
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/linux/d/defs.mk

-3
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/multiple.mk

-12
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/single.mk

-13
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/makefiles/slides.mk

-33
This file was deleted.

chapters/app-interact/overview/guides/demo/fibonacci-server/utils/sock/sock_util.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
#include <unistd.h>
1919
#include <fcntl.h>
2020

21-
#include "utils/utils.h"
22-
#include "utils/log/log.h"
23-
#include "utils/sock/sock_util.h"
21+
#include "../utils.h"
22+
#include "../log/log.h"
23+
#include "sock_util.h"
2424

2525
/*
2626
* Connect to a TCP server identified by name (DNS name or dotted decimal

0 commit comments

Comments
 (0)