Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a style pass over all files #87

Open
cycomachead opened this issue Nov 23, 2015 · 7 comments
Open

Do a style pass over all files #87

cycomachead opened this issue Nov 23, 2015 · 7 comments

Comments

@cycomachead
Copy link
Member

No description provided.

@aaaschmitt
Copy link
Contributor

1d8ce5f
At least the ones in the cs10 directory are style tooled. Using JsFormat plugin for sublime. I'm planning on setting up a build system so that this gets done automatically in the future.

@cycomachead
Copy link
Member Author

We should discuss style... :P

And I want to fix up other files.

@cycomachead cycomachead reopened this Nov 25, 2015
@aaaschmitt
Copy link
Contributor

what the status of this. I really think we should agree on a tool for style and just use it. I think I'm using JsBeautify or something

@cycomachead
Copy link
Member Author

I have an ESLint configure file in the repo which is think is decent. We can have it --fix stuff for us too. But I haven't messed with it in a while.

@aaaschmitt
Copy link
Contributor

@cycomachead please come up with a tool that you like so we can check this issue off the list. What I envision is a script that we can run locally that will clean up all files. The idea is that people just need to try to run this before they commit and if they forgot it's not a big deal. We just need to agree on some sort of style thing so we're consistent.

@cycomachead
Copy link
Member Author

Have you seen eslint ?

There's a WIP config file in the repo. but it needs editing, I think.

@cycomachead
Copy link
Member Author

http://eslint.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants