Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider omitting attribute components #30

Open
csarven opened this issue Feb 2, 2013 · 1 comment
Open

Consider omitting attribute components #30

csarven opened this issue Feb 2, 2013 · 1 comment

Comments

@csarven
Copy link
Owner

csarven commented Feb 2, 2013

Consider omitting attribute components that have quality issues in the data. For example, an attribute value in the data might use a text description of a code instead of a its identifier:

whereas it should be like:

Or there is simply a mismatch between the data and metadata.

These issues are better fixed at the source (and I'm reporting them), however, for the time being it might be better to provide a way to omit them in the results. Obviously precision will be lost but probably better than leaving inaccurate information.

Possible approaches (ordered from easiest to difficult):

  • Offer a config option to omit attributes with a certain @conceptRef
  • Leave everything as is in KeyFamily, but omit the values that have whitespaces (note: is this safe in general for attributes?) in GenericData
  • Omit the component in KeyFamily and the value in GenericData.

Kids, don't manipulate other people's data without parental guidance.

@csarven
Copy link
Owner Author

csarven commented Feb 2, 2013

Commit ef300d3 offers a config to omit certain attributes. Leaving this issue open for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant