-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO and TODOLIST test #2
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test if it works, run the make html
and/or you can use the github action (which is currently getting an error)
…-adding-extention-to-the-test-site
…com/csctd/pechakuchaTest into 1-adding-extention-to-the-test-site
@brownsarahm We think we have the pechakucha working, it displays the pictures. But we need to work on making it more of a slide show, currently we made css and javascript files but they are not displaying on the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the purpose of your grade, there is some cleanup things to do (esp the gitignore related fixes)and both of you need to add the summary report file to you individual kwl repos for credit.
but we can work on making it work better later.
after the cleanup, we can merge this in and i'll help make separate issues to work on a path forward to get this ready to use
_ext/Pechakucha/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better practice to put the class hear in another file and then import it here (and probably import your pechakucha here too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what changes should i make ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the class in a file, instaed of the init and then import it here
_ext/Pechakucha/setup.py
Outdated
install_requires=[ | ||
'Sphinx', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still true; sphinx is a dependency to be able to use your extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im kinda confused on what this statement means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you deleted sphinx as a dependency, which doesn't make sense to me
conf.py
Outdated
extensions = ['pechakucha.pechakucha'] | ||
extensions = [ | ||
'Pechakucha.pechakucha_directive', | ||
#"myst_nb", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you take this one out, then you have to use restructured text, no markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im confused on what you mean by this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you commented out the myst_nb
extension, which was enabled to allow sphinx to understand markdown. without that, it only understands restructured text.
…com/csctd/pechakuchaTest into 1-adding-extention-to-the-test-site
do you have a question for me? I got a notificaiton that i was mentioned, but it looks like i've replied to all? |
are you still working on this? |
yes, i'll email an appointment link. |
Please take a look at this branch and let me know if I did the extension part correctly.
Also will these be the steps for pechakucha?