Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO and TODOLIST test #2

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

Obarrie
Copy link
Contributor

@Obarrie Obarrie commented Dec 8, 2023

Please take a look at this branch and let me know if I did the extension part correctly.

Also will these be the steps for pechakucha?

  1. write the code for the pechakucha in vscode
  2. include it in a file in the GitHub
  3. include that file in conf.py
  4. Add said file to the extensions
  5. and whenever they run "..pechakucha::" it will just do it for them?

@Obarrie Obarrie linked an issue Dec 8, 2023 that may be closed by this pull request
@Obarrie Obarrie requested a review from brownsarahm December 8, 2023 02:42
Copy link
Member

@brownsarahm brownsarahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to test if it works, run the make html and/or you can use the github action (which is currently getting an error)

conf.py Show resolved Hide resolved
someotherfile.rst Outdated Show resolved Hide resolved
@Obarrie
Copy link
Contributor Author

Obarrie commented Dec 17, 2023

@brownsarahm We think we have the pechakucha working, it displays the pictures. But we need to work on making it more of a slide show, currently we made css and javascript files but they are not displaying on the page.
Is what we have good for a grade in the class or should we the javascript and html display one image at a time, allowing the user to decide the interval between the images?

Copy link
Member

@brownsarahm brownsarahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the purpose of your grade, there is some cleanup things to do (esp the gitignore related fixes)and both of you need to add the summary report file to you individual kwl repos for credit.

but we can work on making it work better later.

after the cleanup, we can merge this in and i'll help make separate issues to work on a path forward to get this ready to use

.vs/ProjectSettings.json Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better practice to put the class hear in another file and then import it here (and probably import your pechakucha here too)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what changes should i make ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the class in a file, instaed of the init and then import it here

Comment on lines 7 to 9
install_requires=[
'Sphinx',
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still true; sphinx is a dependency to be able to use your extension

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im kinda confused on what this statement means

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you deleted sphinx as a dependency, which doesn't make sense to me

conf.py Outdated
extensions = ['pechakucha.pechakucha']
extensions = [
'Pechakucha.pechakucha_directive',
#"myst_nb",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you take this one out, then you have to use restructured text, no markdown.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im confused on what you mean by this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you commented out the myst_nb extension, which was enabled to allow sphinx to understand markdown. without that, it only understands restructured text.

_ext/todo.py Outdated Show resolved Hide resolved
@brownsarahm
Copy link
Member

do you have a question for me? I got a notificaiton that i was mentioned, but it looks like i've replied to all?

@brownsarahm
Copy link
Member

are you still working on this?

@Obarrie
Copy link
Contributor Author

Obarrie commented Feb 27, 2024 via email

@brownsarahm
Copy link
Member

yes, i'll email an appointment link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding extention to the test site
3 participants