Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added components.json #21

Merged
merged 2 commits into from
Oct 15, 2023
Merged

added components.json #21

merged 2 commits into from
Oct 15, 2023

Conversation

Kris0011
Copy link
Contributor

This PR is related to issue #16 .
By using javascript fetch method I am fetching all the data from the components.json file and converting into a HTML div which has classes of the component card . (Card's style is same as before)

Changes :

  • Added components.json .
  • Removed all cards from components.html file , cards will be shown via script .
  • Modified readme to show how to contribute new component .

Things to be considered now onwards :

  • Every components should be added in the same manner shown in this PR .
  • Each component should contain index.html file .
  • Images should be added of the component into images directory .
  • To show the component into components.html modify components.json file accordingly.

@github-actions
Copy link

Hello! 👋 Thank you @Kris0011 for your pull request!
We appreciate your contribution to "Frontend-Treasure" for Hacktoberfest. Your effort helps make our project better. 🌟
Our team will review your PR soon. In the meantime, feel free to explore more ways to contribute or join our community discussions. Your involvement is important to us!
Keep up the great work! 🚀

@Kris0011 Kris0011 closed this Oct 15, 2023
@Kris0011 Kris0011 reopened this Oct 15, 2023
@Nisarg155 Nisarg155 added documentation Improvements or additions to documentation hacktoberfest-accepted enhancement New feature or request labels Oct 15, 2023
@Nisarg155 Nisarg155 merged commit 2640a9d into csiddu:main Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nisarg155 Nisarg155 Nisarg155 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kris0011 @Nisarg155