Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on other library #3

Open
itsarbit opened this issue Jul 27, 2016 · 1 comment
Open

Dependency on other library #3

itsarbit opened this issue Jul 27, 2016 · 1 comment

Comments

@itsarbit
Copy link
Contributor

Hey,

Currently, test library has a dependency on github.com/nats-io/gnatsd, which should not be a required third party dependency. Actually, it is imported in gnatsd.go. I believe it would be better to remove this dependency.

Thanks.

@hsinhoyeh
Copy link

I see, that makes sense as well.
we can organize them into subpackage, like

csigo/test/gnatsd
csigo/test/hbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants