Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma-Separated Values #74

Open
alexlafroscia opened this issue Oct 5, 2016 · 5 comments
Open

Comma-Separated Values #74

alexlafroscia opened this issue Oct 5, 2016 · 5 comments

Comments

@alexlafroscia
Copy link

I'm seeing problems when trying to use an @value with a font-family definition. For example:

@value my-font-fam: 'Some-Custom-Font', Helvetica;

.foo {
  font-family: my-font-fam;
}

Results in:

.foo {
  font-family: 'Some-Custom-Font';
}

A longer @value definition, such as

@value my-font-fam: 'Some-Custom-Font', Helvetica, Arial, 'Lucida Granda', sans-serif;

results in the same output.

Possibly related to #68 (issues with comma-separated media queries) but I'm not sure.

@alexlafroscia
Copy link
Author

I see that there's a test here verifying that they should be supported... I'm not sure why I'm running into problems here.

@mndewitt
Copy link

Appears to be an issue with the single quotes - I've been able use commas in media queries.

@OliverJAsh
Copy link

I've also just been hit by this. Is there any known work around?

@TrySound
Copy link
Member

TrySound commented Jun 3, 2017

Well, guys. I can't reproduce this issue. Can you help with debugging?

@OliverJAsh
Copy link

My example is almost identical to the original post: using @value to store the font family value, which contains commas.

@value fontFamilyValue: foo, bar, baz

body {
  font-family: fontFamilyValue;
}

Result is:

body {
  font-family: foo;
}

I am reproducing this when using CSS Modules via css-loader’s modules option, if that has anything to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants