Fix user archival #434
Merged
Fix user archival #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilco375
commented
Oct 11, 2024
lodewiges
approved these changes
Oct 11, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #428
User archival failed because a form can only have one response per user, but if multiple responses are archived they all get user id 0, which caused this validation to fail. The validation now explicitly excludes the archived user (id 0).
I also changed the user update statement to throw an error once an update fails. This makes it more clear where the error occurs. Regardless of this, user archival will fail anyways if the update fails because of foreign key constraints once the user is attempted to be deleted (as has been happening until now).