From b4b0af3b6289f3dc62f47ff2491dbb7abb768008 Mon Sep 17 00:00:00 2001 From: Maximilian Linhoff Date: Tue, 19 Sep 2023 13:09:14 +0200 Subject: [PATCH] Add changelog --- docs/changes/2396.api.rst | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 docs/changes/2396.api.rst diff --git a/docs/changes/2396.api.rst b/docs/changes/2396.api.rst new file mode 100644 index 00000000000..d979c86773e --- /dev/null +++ b/docs/changes/2396.api.rst @@ -0,0 +1,7 @@ +Drop support for computing image parameters in ``CameraFrame`` (meters on the camera plane). +Going forward, ctapipe only implements computing image parameters in telescope frame (degrees on the sky). + +* ``ctapipe-process`` and ``ImageProcessor`` no longer have options to chose between ``CameraFrame`` and ``TelescopeFrame``` +* All image parameter functions do not support inputs in length units anymore +* If using these low-level funtions directly in your code, you will need to transform your camera geometries into ``TelescopeFrame`` + using ``geometry.transform_to(TelescopeFrame)``. This requires a correctly set ``frame`` attribute with a ``focal_length`` on the ``CameraGeometry``. If reading files using the ``SimTelEventSource`` or ``HDF5EventSource``, this is already the case, io plugins might need to adapt.