Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise PointingInterpolator for calibration parameters #2565

Open
ctoennis opened this issue Jun 19, 2024 · 0 comments
Open

Generalise PointingInterpolator for calibration parameters #2565

ctoennis opened this issue Jun 19, 2024 · 0 comments
Assignees

Comments

@ctoennis
Copy link

ctoennis commented Jun 19, 2024

Please describe the use case that requires this feature.
For the use cases DPPS-UC-120-2.21 (calculating and calibrating pedestals), DPPS-UC-120-2.22 (calculating and calibrating gain), and DPPS-UC-120-2.28 (Pointing corrections) calibration parameters will be generated that will need some form of interpolation similar to the basic pointing information (linear interpolation for the pointing correction and a sort of step function-like interpolation for gain and pedestals).

Describe the solution you'd like
I would like to modify the PointingInterpolator into a more general interpolator class that is told which data to interpolate and which interpolation method is to be used.

Describe alternatives you've considered
Alternatively we can have a new interpolator class for the pedestals and gain as they need a different method of interpolation and simply just modify the PointingInterpolator to also handle pointing corrections.

Additional context
Link to pull request:
Pull request
Links to the use cases:
Pedestals
gain
Pointing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant