Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMAS2021 container is slow to start up #6

Open
yanj-github opened this issue Jun 6, 2024 · 3 comments
Open

WMAS2021 container is slow to start up #6

yanj-github opened this issue Jun 6, 2024 · 3 comments

Comments

@yanj-github
Copy link

Docker compose takes really long to start up at "INFO:manifest:Updating manifest". It attempts to rebuild manifest file and which takes long time. Can we include the right manifest generation / build to the image so it is quicker to spin up docker container please?

I can see from Dockerfile https://github.com/cta-wave/WMAS-deploy/blob/wmas2021/Dockerfile it runs "RUN ./wpt manifest --no-download --rebuild" already, however, it seems that the manifest built again when container is starting. Is it required to build manifest again?

@FritzHeiden
Copy link
Collaborator

We know about this for a little while now and had several attempts to fix this (the line in the docker file is one attempt). At this point, what we can do about it is either ask the developers of the original wpt runner or try to modify the code of the wpt runner (which we didn't touch so far).

I don't really like the idea of modifying the original test runner code, as this would potentially introduce more conflicts when syncing with upstream and when merging changes back into the original wpt project.

@jpiesing
Copy link

jpiesing commented Jun 6, 2024

@FritzHeiden Did you open an issue against the original WPT runner to see how they react? Sure they may react negatively or not at all but you'll never know if you don't try?

@yanj-github
Copy link
Author

@FritzHeiden do you know which WMAS versions have this issue please? I can see WMAS2018 is quick to start up. Is this because wpt runner for WMAS2018 runs differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants