-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test runner / deployment: HbbTV / Smart TV friendly landing page #61
Comments
This issue may turn into nothing if the test engineer would never need to interact with this page on a device under test - only read the first 8 characters of the token. |
@jpiesing the landing page now includes a javascript lib (hbbtv.js) which checks via the User Agent if the test runs on HbbTV terminal and if yes, it do the additional initialisations required for HbbTV. |
HATF March 2nd update - @louaybassbouss will provide a screencast of the test set up |
@louaybassbouss and @jpiesing correct me please if I am wrong. On the TR individual test always starts with pre-test.html (only for dpctf tests not applicable for WMAS) before it goest to actual test HTML+JS. |
@louaybassbouss I think we would like to have a javascript lib (hbbtv.js) included for all the pages that the Device Under Test needs to serve as part of running the WMAS tests and DPCTF tests please? HTML pages that should be on companion device are not required. |
@yanj-github hbbtv.js is now included in all HTML files. |
Thank you very much @FritzHeiden I can see changes for DPCTF test on master branch. |
WMAS Tests are forked from WPT Project without modifications it is difficult to include hbbtv.js in thousands of files. This is why hbbtv.js is only included on the Landing Page (https://webapitests2019.ctawave.org/wave/index.html). In out test, HbbTV initialisation on the landing page was sufficient. Are you facing issues? if yes can you share details. |
@louaybassbouss Yes indeed, I understand this involve in changing thousands of files. Is it eaiser to have a HbbTV-specific landing page (already bind the session tocken) instead of standard index.html? Something like "https://webapitests2019.ctawave.org/wave/index.html?token=xxxxxxx" |
@yanj-github You can use /wave/next.html?token=xxxx to execute the next test in the session. However, hbbtv.js is still required to be added to next.html |
Thanks @FritzHeiden That might be a approach. Will time delay between start test and /wave/next.html?token=xxxx cause any missed tests run at the begining? |
Start test will set some session properties and invoke appropriate events. The test runner registers running and completed tests upon actually requesting a test to execute. This happens on the landing page, in test files when they are finished, as well as in next.html, so there should be no tests missing due to any delays. |
Thanks @FritzHeiden I just checked the DPCTF tests, by landing on /wave/next.html?token=xxxx which works fine. |
@yanj-github I added the hbbtv.js to next.html and added another query parameter "delay", which will delay the test execution by the provided value in ms. This may help if the redirection to the test is faster than hbbtv takes to initialize. |
@FritzHeiden Can you provide information of where I can set this "delay" please? |
@yanj-github this is an example https://webapitests2019.ctawave.org/wave/index.html?token=xxxxxxx&delay=3000 . This will delay the redirection for 3s. |
Thanks @louaybassbouss I just tried with one test this is working fine. |
@jpiesing let us know if you would like to see anything further or if this can be closed |
Based on @yanj-github 's comment above, I'm OK to close this. |
The landing page used in WMAS (and re-used in DPCTF) is not very HbbTV friendly and probably not very friendly towards Smart TVs in general.
It would be good to have a more Smart TV / HbbTV friendly landing page.
It may be more appropriate to have two pages;
The text was updated successfully, but these errors were encountered: