Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning if frame rate of recording is insufficient for test being run #87

Closed
jpiesing opened this issue Aug 6, 2024 · 5 comments
Closed
Assignees
Labels
Released Released and ready for check

Comments

@jpiesing
Copy link

jpiesing commented Aug 6, 2024

Please can the OF generate a warning if the frame rate of the recordings is insufficient for the tests being run, e.g. a 30Hz recording with 25Hz tests or a 60Hz recording where the p50/p60 tests have not been removed.

@yanj-github
Copy link
Collaborator

Thanks for reporting @jpiesing this warning can be added when OF process to the pre-test QR codes.

@jpiesing
Copy link
Author

jpiesing commented Aug 6, 2024

Thanks for reporting @jpiesing this warning can be added when OF process to the pre-test QR codes.

Thinking about it some more, I wonder if this should be an automatic fail of the test?

@yanj-github
Copy link
Collaborator

Thanks for reporting @jpiesing this warning can be added when OF process to the pre-test QR codes.

Thinking about it some more, I wonder if this should be an automatic fail of the test?

We can still give test result but add warning to the result message.

@yanj-github yanj-github added the In progress In progress label Sep 2, 2024
yanj-github pushed a commit to yanj-github/device-observation-framework that referenced this issue Sep 16, 2024
rcottingham added a commit that referenced this issue Sep 16, 2024
@yanj-github yanj-github added Released Released and ready for check and removed In progress In progress labels Sep 16, 2024
@yanj-github
Copy link
Collaborator

Changes made to the master please review can close the issue when you happy.

@jpiesing
Copy link
Author

I trust you. I'm not in in a position to test this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released Released and ready for check
Projects
None yet
Development

No branches or pull requests

2 participants