Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client interview screening table #74

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Conversation

dlacuata
Copy link
Contributor

@dlacuata dlacuata commented Feb 6, 2025

Description

Added table for client interview screening comments

Screenshots/Media

image

Issues

Closes #57

Search functionality was originally requested but we didn't really know how exactly this should function, Benson just said we can fix after review.

Copy link
Collaborator

@benson-fm benson-fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the PR guys, you guys did really well, just a few things to change, it is listed that there are a few merges conflicts but Sean and I will handle that. We'll send you guys information on what to do for search asap

Comment on lines 50 to 51
//console.log(screeningCommentsResponse.data);
//console.log(items);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove these

Comment on lines 80 to 99
<MenuItem>Initial Interview ID</MenuItem>
<MenuItem>Case Manager ID</MenuItem>
<MenuItem>Willingnes</MenuItem>
<MenuItem>Employability</MenuItem>
<MenuItem>Attitude</MenuItem>
<MenuItem>Length Of Sobriety</MenuItem>
<MenuItem>Completed TX</MenuItem>
<MenuItem>Drug Test Results</MenuItem>
<MenuItem>Homeless Episode One</MenuItem>
<MenuItem>Homeless Episode Two</MenuItem>
<MenuItem>Homeless Episode Three</MenuItem>
<MenuItem>Homeless Episode Four</MenuItem>
<MenuItem>Disabling Condition</MenuItem>
<MenuItem>Employed</MenuItem>
<MenuItem>Driver License</MenuItem>
<MenuItem>Number of Children</MenuItem>
<MenuItem>Children In Custody</MenuItem>
<MenuItem>Last City Permanent Residence</MenuItem>
<MenuItem>Decision</MenuItem>
<MenuItem>Additional Comments</MenuItem>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can condense this with using a map function, how you would do it is that you would hold a javascript object that would have the key and labels of these different items, and then call on that to make the menu items

Comment on lines 106 to 126
<Tr>
<Th>Initial Interview ID</Th>
<Th>Case Manager ID</Th>
<Th>Willingness</Th>
<Th>Employability </Th>
<Th>Attitude</Th>
<Th>Length of Sobriety</Th>
<Th>Completed TX</Th>
<Th>Drug Test Results</Th>
<Th>Homeless Episode One</Th>
<Th>Homeless Episode Two</Th>
<Th>Homeless Episode Three</Th>
<Th>Homeless Episode Four</Th>
<Th>Disabling Condition</Th>
<Th>Employed</Th>
<Th>Driver License</Th>
<Th>Number of Children</Th>
<Th>Children In Custody</Th>
<Th>Last City Permenant Residence</Th>
<Th>Decision</Th>
<Th>Additional Comments</Th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here as well

Comment on lines 76 to 78
<MenuButton as={Button}>
Sort
</MenuButton>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When its come to your sort button, add the functionality for sorting. Create another API endpoint that would take the attribute and use that to dictate the ascending order in the SQL statement

Comment on lines 3 to 32
Button,
Link as ChakraLink,
FormControl,
FormLabel,
Heading,
Input,
Stack,
VStack,
Radio,
RadioGroup,
Textarea,
useToast,
Select,
HStack,
Text,
Table,
Thead,
Tbody,
Tfoot,
Tr,
Th,
Td,
TableCaption,
TableContainer,
Flex,
Menu,
MenuButton,
MenuList,
MenuItem,
} from "@chakra-ui/react";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a few thing you guys are importing that could be deleted since you guys aren't using them

Copy link
Collaborator

@benson-fm benson-fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys I added a description on what to do for the Search Input

</Flex>
</HStack>
<HStack>
<Input placeholder='Search' />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the search functionality, take inspiration from that of what's currently in ClientList and what they implement for the search functionality, it should be identical to that, you may need to make a another API endpoint but I would also just look into how they implemented it and take inspiration from that

…lity for adding search queries and sort by asc for different variables
@dlacuata dlacuata requested a review from benson-fm February 9, 2025 02:06
@benson-fm benson-fm merged commit c6e0237 into main Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Interview Screening Comment Table
3 participants