Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Articles and Event Enrollments CRUD Routes #36

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Create Articles and Event Enrollments CRUD Routes #36

merged 9 commits into from
Jan 10, 2025

Conversation

Priyansh4444
Copy link
Member

Description

Create Articles and Event Enrollments CRUD Routes in articles.ts and event_enrollments.ts

Screenshots/Media

Postman Results:

Articles

image
image
image
image
image
image
image

Event Enrollments

image

Issues

Closes #32

@Priyansh4444 Priyansh4444 linked an issue Dec 27, 2024 that may be closed by this pull request
Create Articles and Event Enrollments CRUD Routes #32
Closed
@Priyansh4444
Copy link
Member Author

I don't know how I would test the EventEnrollments page since we don't have the implementations of the students and events APIs / databases (which are required to post to the events page since the databases rely on foreign keys)

@h0ethan04
Copy link
Collaborator

I don't know how I would test the EventEnrollments page since we don't have the implementations of the students and events APIs / databases (which are required to post to the events page since the databases rely on foreign keys)

You should have access to the prod db -- if you edit it and add a row for students and a row for events using a sql query you should be able to get the data from the neondb postgres instance and test using the remote instance.

@Arapaimace
Copy link
Contributor

Screenshots for event enrollments:
Screenshot 2024-12-26 at 9 43 01 PM
Screenshot 2024-12-26 at 9 44 55 PM
Screenshot 2024-12-26 at 9 45 31 PM
Screenshot 2024-12-26 at 9 47 01 PM

@Priyansh4444 Priyansh4444 marked this pull request as ready for review December 27, 2024 07:01
h0ethan04
h0ethan04 requested changes Jan 7, 2025
View reviewed changes
server/routes/articles.ts Outdated Show resolved Hide resolved
server/routes/articles.ts Outdated Show resolved Hide resolved
server/routes/articles.ts Outdated Show resolved Hide resolved
server/routes/articles.ts Outdated Show resolved Hide resolved
server/routes/event_enrollments.ts Outdated Show resolved Hide resolved
server/routes/event_enrollments.ts Outdated Show resolved Hide resolved
server/routes/event_enrollments.ts Outdated Show resolved Hide resolved
server/routes/articles.ts Outdated Show resolved Hide resolved
server/routes/event_enrollments.ts Outdated Show resolved Hide resolved
stevem-zhou
stevem-zhou approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@stevem-zhou stevem-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevem-zhou stevem-zhou merged commit 85ab1ed into dev Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h0ethan04 h0ethan04 h0ethan04 approved these changes

@stevem-zhou stevem-zhou stevem-zhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Articles and Event Enrollments CRUD Routes
4 participants
@Priyansh4444 @h0ethan04 @Arapaimace @stevem-zhou