-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fgsea hangs forever for highly enriched pathways in the presence of repeated high scored genes #151
Comments
@guidohooiveld thanks for the report. I can reproduce the problem. I'll check later what's going on. |
To keep you updated: this is turned out to be an issue of the algorithm we were generally aware of, although not in this setting. Anyway we recently developed an approach how to properly fix it. Hopefully we'll be able to integrate the proper fix into fgsea in not so distant future, but also it's not trivial, so I can't make any ETA. As a workaround for now one could add random noise to the input scores, and everything should start working fine:
|
Hello, |
|
The solution with |
@jinxmeng Thanks for your comment, but I suspect it to be a different bug. It'd be great if you could provide more background, like was there anything special about your input and how reproducible it in your settings. We don't test it on Windows machines too much, but my understanding was that it should run OK, even without |
@yeroslaviz Similarly, I'm not sure what's going on in your case. I saw your post on Biostars, apparently you use Mac, not Windows, and also had |
@assaron Thank you for your response. I don't fully understand the operating mechanism here. I will provide the relevant files and code for you to test. Thank you! My computer system is Microsoft Windows 11, and my CPU is 'Intel64 Family 6 Model 183 Stepping 1 GenuineIntel ~2100 MHz' (Intel(R) Core(TM) i7-14700HX, 2100 MHz, 20 cores).
|
@assaron - you're correct. the serialParam() didn't solve the problem, when I tried it again, but your suggestion to add random noise did. So, for now I'm happy about it. That's also the reason, why I deleted the comment on Biostar. thanks for the solution. It would be great if you can also fix the problem in the future. |
Hi Alex,
A (reproducible) issue ("GSEA hangs") was posted on the
clusterProfiler
GitHub.See: YuLab-SMU/clusterProfiler#659 (comment), and posts below that one.
Since
clusterProfiler
uses under the hoodfgsea
for gene set enrichment analysis, I checked whether the reported issue originates from the way input/output data is being processed byclusterProfiler
, or fromfgsea
. It turns that I could reproduce the issue when directly usingfgsea
, hence this post.Please note that the OP reported this issue when using
R-4.2.2
, but I could reproduce it also with the current versions of R (R-4.3.0
resp.R-4.3.3
) andfgsea
on both my Windows resp. Linux machines.Also note that the issue occurs when
minSize
is set to 10; whenminSize=11
is uedfgsea
runs as expected...For your convenience I have attached the 2 input files to this post as
RData
file (which I compressed into an ZIP archive in order to be able to upload it). See below how these objects were generated, also in case you would like to generate them yourselves.I would appreciate if you could have a look at this to see whether this can be fixed.
G
sessionInfo()
Windows machine:sessionInfo()
Linux machine:fgsea.input.zip
The text was updated successfully, but these errors were encountered: