Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Add support for custom path bases #9

Open
poke opened this issue Feb 1, 2018 · 1 comment
Open

Add support for custom path bases #9

poke opened this issue Feb 1, 2018 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@poke
Copy link
Collaborator

poke commented Feb 1, 2018

When you do app.UsePathBase("/foo") the whole app basically runs at the subpath /foo. So the sitemap at /foo/sitemap.xml should generate paths that respect that path base.

This would usually be super simple, but the middleware is registered using applicationBuilder.Map(…). And the way the MapMiddleware works is by adjusting the path base itself.

So we have to change the way we are matching the path and will likely have to do that within the middleware itself instead. But doing that will actually help us with #5 so we can serve different endpoints later.

@poke poke self-assigned this Feb 1, 2018
@ctolkien ctolkien added the help wanted Extra attention is needed label Feb 22, 2018
@ctolkien
Copy link
Owner

ctolkien commented Feb 6, 2019

Is there a better way to register this other than MapMiddleware ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants