-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for child ProgressBar #70
base: 1.0
Are you sure you want to change the base?
Conversation
Wow! Thanks @vehovsky !!! |
I think that this proposal need more discussion. There are two cases with parent/children progress bars:
I think what you implemented here is the second case. |
Yes it is initial implementation only. Well the actual progress of the parent is calculated as average of all it children/subchildren/etc. progresses. It is true the "max" of parent is only size of immediate children, not subchildren/etc. So instead:
Something like:
|
Yes and I think that we need to discuss to understand the subtle semantics of the two cases. In the meantime, I'm thinking of releasing an interim |
@ctongfei Can you release 0.9? |
@nadilas 0.9.0 was relased https://github.com/ctongfei/progressbar/blob/master/CHANGELOG.md I am a bit worried about the conflicts here. Maybe @vehovsky can fix them? 😇 |
Hey, don't mean to be annoying, but is there any ETA on when this can be released? |
Let's try this again 😅 @koppor How can we help? |
It would be great if better multiline support could be added for 0.9. And I would also like to add another scenario to this, or clarify if it is already covered by this.
My scenario would be similar, e.g. parent has |
@leonard84 Seems someone needs to redo this PR - and @vehovsky seems to be inactive. Anyone volunteering for the sake of hacktoberfest? |
Initial implementation. Build on top of #69
Fixes #66