Tests for plot recipes #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/runtests.jl
Outdated
| Lx, y, z = Lx_slice(joinpath(dir, file), λ, 0) | ||
| @test length(Lx) > 0 | ||
| @test length(Lx) == length(y) == length(z) | ||
| dir = "/mnt/storage/epoch/Wang-Arefiev2020mod/12mtt_0.8w0_l0_MDO" |
There was a problem hiding this comment.
We could use the CI env variable to see what path to use. In case we are on CI, we could use the .sdf in the test folder.
|
CI fails because it doesn't have the custom registry added |
Open
Co-authored-by: Sebastian Micluța-Câmpeanu <[email protected]>
SebastianM-C
requested changes
Mar 31, 2021
| @test length(Lx) > 0 | ||
| @test length(Lx) == length(y) == length(z) | ||
| dir = "/mnt/storage/epoch/Wang-Arefiev2020mod/12mtt_0.8w0_l0_MDO" | ||
| sim = read_simulation(dir) |
There was a problem hiding this comment.
You need to add using SDFResults for this to work
|
CI should work on linux now. On windows there is a problem with adding the registry and on MacOS there is an issue with PyCall |
SebastianM-C
approved these changes
Apr 12, 2021
|
@DolineanuMircea We should create some simple simulations which contain the data that we need (like photons or particle weights) and add it for the tests. It shouldn't be larger than the current sdf in the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.