Skip to content
This repository was archived by the owner on Jun 3, 2019. It is now read-only.

Upgraded Styled Components branch/example #492

Closed
oyeanuj opened this issue Sep 5, 2017 · 6 comments
Closed

Upgraded Styled Components branch/example #492

oyeanuj opened this issue Sep 5, 2017 · 6 comments

Comments

@oyeanuj
Copy link
Contributor

oyeanuj commented Sep 5, 2017

Hi folks! I noticed that the styled-components feature branch is still on v1 of the library. I've had some trouble upgrading but I figured some other folks here might have already upgraded.

Is there an example fork/branch somewhere that one could look at, and maybe PR back to upgrade that feature branch?

@oyeanuj oyeanuj changed the title Upgrade StyledComponent branch Upgraded Styled Components branch/example Sep 5, 2017
@strues
Copy link
Collaborator

strues commented Sep 5, 2017

Updated the styled-components branch with version 2.

@strues strues closed this as completed Sep 6, 2017
@oyeanuj
Copy link
Contributor Author

oyeanuj commented Sep 6, 2017

@strues Thank you!

@oyeanuj
Copy link
Contributor Author

oyeanuj commented Sep 27, 2017

@strues Noticed that the styled-components feature branch that you merged has two issues noted in the FEATURE_STYLED_COMPONENTS document. But both those issues seem to have been resolved in the original SC repo.

Do you know if the Feature Document is out of date or if those still need to be implemented in feature branch?

@strues
Copy link
Collaborator

strues commented Sep 27, 2017

It's out of date @oyeanuj. Last time it was updated was against v12. I'll get around to updating those docs in the morning.

@oyeanuj
Copy link
Contributor Author

oyeanuj commented Sep 29, 2017

@strues thanks. I also noticed that in the code here, when SSR is disabled, we are using the sheet to collect styles but not retrieving styleTags from there.

It seems like either we should be doing that (like we do for SSR below), or not need to call sheet.collectStyles when not doing SSR. Thoughts?

@oyeanuj
Copy link
Contributor Author

oyeanuj commented Oct 1, 2017

@strues Also, I removed one of the notes as part of #505. I'm not sure about what the first one is referring to import vs require.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants