Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure entities aren't created when using new merged geometries #3

Open
kfarr opened this issue Oct 29, 2024 · 1 comment
Open

Comments

@kfarr
Copy link

kfarr commented Oct 29, 2024

it appears that building entities are being created?

Instead perhaps something like this?
3DStreet@a866a96

@ctrlw
Copy link
Owner

ctrlw commented Oct 29, 2024

Thanks, I've pushed 51b7dcdb to avoid this and clean up leftovers.

The mergeGeometries vs mergeBufferGeometries seems to be a dependency topic. In 979b918 I've added an (unversioned) dependency on BufferGeometryUtils, which apparently differs from the version you're using. Would the following help in addBuildings?

const mergeGeometries = THREE.BufferGeometryUtils.mergeBufferGeometries ? THREE.BufferGeometryUtils.mergeBufferGeometries : THREE.BufferGeometryUtils.mergeGeometries;
let geometry = mergeGeometries(geometries, false);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants