Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when adding OSGi aspect after upgrade to v0.12. #144

Open
zaunerc opened this issue Mar 15, 2016 · 5 comments
Open

Exception when adding OSGi aspect after upgrade to v0.12. #144

zaunerc opened this issue Mar 15, 2016 · 5 comments
Assignees

Comments

@zaunerc
Copy link

zaunerc commented Mar 15, 2016

I have upgraded from package drone version 0.11 to 0.12.1.20160211-1555. When adding the OSGi aspect I get an exception. Adding other aspects works so far.

Attached files:

@ctron
Copy link
Owner

ctron commented Mar 15, 2016

That looks strange. Did you see the version number in the exception?

@zaunerc
Copy link
Author

zaunerc commented Mar 16, 2016

Yes. The problem is that the OSGi version of the xstream-1.4.8-sources bundle is erroneous:

xstream-1 4 8-sources-osgi-version

Maybe some OSGi related sanity checks should be run when importing artifacts into a channel with the OSGi aspect enabled. See e.g. the following screenshot:

import_test

I think the import test report should uncheck the xstream-1.4.8-sources bundle and tell the user that the version information in the OSGi manifest file is erroneous (like it did with the missing xmlpull javadoc and sources artifacts).

By the way. When adding the OSGi aspect after importing the artifacts you will get the following stacktrace: import_after_aspects.txt

@ctron
Copy link
Owner

ctron commented Mar 16, 2016

Ok, this I clearly a case then for the OSGi validator. I already detects and reports illegal bundle symbolic names. So the artifact would be uploaded, but not processed as OSGi bundle. And a validation error would be attached to the artifact and channel.

@ctron ctron self-assigned this Mar 16, 2016
ctron added a commit to eclipse-archived/packagedrone that referenced this issue Mar 16, 2016
@ctron
Copy link
Owner

ctron commented Mar 16, 2016

It would look like that now:

pd013_fix_osgi1
pd013_fix_osgi2

@zaunerc
Copy link
Author

zaunerc commented Mar 16, 2016

This looks perfectly fine to me. Thanks for coming up with a fix that quick :-)

ctron added a commit to eclipse-archived/packagedrone that referenced this issue Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants