From 0a71bfa94d4b721abcf4fcf330ef9b2a7f707db3 Mon Sep 17 00:00:00 2001
From: Thomas Nicholas <thomas.nicholas@columbia.edu>
Date: Tue, 1 Aug 2023 16:35:04 -0400
Subject: [PATCH] test edge cases

---
 cubed/tests/test_core.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/cubed/tests/test_core.py b/cubed/tests/test_core.py
index 5588167c..bd750146 100644
--- a/cubed/tests/test_core.py
+++ b/cubed/tests/test_core.py
@@ -283,12 +283,17 @@ def test_max_mem_deprecation_warning(self):
         [
             (500, 500),
             (100_000, 100_000),
+            (50.0, 50),
             ("500B", 500),
             ("1kB", 1000),
             ("1MB", 1000**2),
             ("1GB", 1000**3),
             ("1TB", 1000**4),
             ("1PB", 1000**5),
+            ("100_000", 100_000),
+            ("1.2MB", 1.2 * 1000**2),
+            ("1 MB", 1000**2),
+            ("1.2 MB", 1.2 * 1000**2),
         ],
     )
     def test_convert_to_bytes(self, input_value, expected_value):
@@ -302,7 +307,8 @@ def test_convert_to_bytes(self, input_value, expected_value):
             "1kb",  # lower-case k is not valid
             "invalid",  # completely invalid input
             -512,  # negative integer
-            1000.0,  # invalid type
+            "kB",  # only unit, no value
+            "1.1B",  # can't have a fractional number of bytes
         ],
     )
     def test_convert_to_bytes_error(self, input_value):