Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed commands related to selection #132

Closed
wants to merge 1 commit into from
Closed

Fixed commands related to selection #132

wants to merge 1 commit into from

Conversation

mathiascode
Copy link
Member

@mathiascode mathiascode commented Aug 21, 2017

Commands that requires the player to select an area broke after a recent Cuberite update. This seems to fix the problem.

Fixes #131

@madmaxoft
Copy link
Member

This is not good, because you're modifying the internal self.Cuboid. This causes problems with the selection - the first point and second point of selection get mixed up.

The original code created a copy of the cuboid, then sorted it. It needs to stay that way, the problem is in Cuberite itself, not in WE.

@madmaxoft madmaxoft closed this Aug 21, 2017
@mathiascode mathiascode deleted the fixcommands2 branch August 21, 2017 19:03
@Buom01
Copy link

Buom01 commented Aug 27, 2017

For me, this seem working (see https://api.cuberite.org/cCuboid.html#Assign_1):

function cPlayerSelection:GetSortedCuboid()
        assert(self:IsValid())

        local SCuboid = cCuboid()
        SCuboid:Assign(self.Cuboid)
        SCuboid:Sort()
        return SCuboid;
end

I tested //copy //paste with success


However, I'm trying to repair the issues directly in cuberite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when executing //walls or //set
3 participants