Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Canonical Transformations To Be Unique Under Subsumption #50

Open
Checkmate50 opened this issue Feb 27, 2019 · 1 comment
Open
Assignees
Labels
testing requires update to the testing framework

Comments

@Checkmate50
Copy link
Contributor

Canonical transformations are assumed to be unique -- there is exactly one canonical map between two coordinate systems. While this is not in fact always true (read: homogeneous coordinates), it is both best practice and most sensical to treat them as such. The only reason we currently do not do this is to allow the norm to homogeneous coordinates hack, something that was found to be done incorrectly from a type perspective.

Practically this means that invocations of in should fail if there are multiple ways to reach label B from label A in a single step (including subsumption). Note that this does not require checking if multiple paths exist over the course of several steps, as we assume that the programmer has checked that each of these paths are equivalent (see https://github.com/cucapra/linguine/wiki/Tutorial:-Casting-and-In-Expressions for details).

@Checkmate50 Checkmate50 self-assigned this Feb 27, 2019
@Checkmate50
Copy link
Contributor Author

We should add tests to check this

@Checkmate50 Checkmate50 added the testing requires update to the testing framework label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing requires update to the testing framework
Projects
None yet
Development

No branches or pull requests

1 participant