From 9ae15e1e453a1fe0f241c2d1162f95924b993ea0 Mon Sep 17 00:00:00 2001 From: Cucumber Ensemble Date: Wed, 14 Jul 2021 20:51:57 +0000 Subject: [PATCH 1/2] Explain how to use yarn to list commands Co-authored-by: Matt Wynne --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ee7a43ea9..4fe0183f9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,7 +9,7 @@ Before anything else, thank you. Thank you for taking some of your precious time ## Tests -See the `package.json` scripts section for how to run each category of tests. +Now type `yarn run` or see the `package.json` scripts section for how to run each category of tests. * lint - `yarn lint` * [prettier](https://github.com/prettier/prettier) From 18b3ff3f7836dbb18a53c49a1d360f4e346729e0 Mon Sep 17 00:00:00 2001 From: Cucumber Ensemble Date: Fri, 16 Jul 2021 18:01:49 +0000 Subject: [PATCH 2/2] Make parameter type generic for value checker Co-authored-by: Arti Co-authored-by: Demi Co-authored-by: Marju Co-authored-by: Matt --- src/value_checker.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/value_checker.ts b/src/value_checker.ts index 238577974..7aa7a25c7 100644 --- a/src/value_checker.ts +++ b/src/value_checker.ts @@ -1,8 +1,8 @@ -export function doesHaveValue(value: any): boolean { +export function doesHaveValue(value: T): boolean { return !doesNotHaveValue(value) } -export function doesNotHaveValue(value: any): boolean { +export function doesNotHaveValue(value: T): boolean { return value === null || value === undefined }