Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment inside Free Form Description not allowed #333

Open
jacob-wieland-gematik opened this issue Dec 9, 2024 · 3 comments
Open

Comment inside Free Form Description not allowed #333

jacob-wieland-gematik opened this issue Dec 9, 2024 · 3 comments
Labels
🐛 bug Defect / Bug

Comments

@jacob-wieland-gematik
Copy link

👓 What did you see?

If you write a feature with a comment inside of the description, the file cannot be parsed successfully. (I assume the same is true for all free form descriptions). The parser once entering the comment state will not return to the description state after parsing the comment.

✅ What did you expect to see?

From the documentation, a comment does not end a description section. It supposedly is ended only by one of the keywords and comment is not mentioned as one of the keywords.

📦 Which tool/library version are you using?

No response

🔬 How could we reproduce it?

Feature: X Z Y

Some Description
# Comment
Some more Description

📚 Any additional context?

No response

@kieran-ryan
Copy link
Member

kieran-ryan commented Dec 29, 2024

Thanks a mill for report @jacob-wieland-gematik, just checking is it the Java parser implementation you are using? Assume applies to all parser implementations; though something to be checked.

Edit: Observe #334

@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Dec 29, 2024
@jacob-wieland-gematik
Copy link
Author

jacob-wieland-gematik commented Jan 2, 2025

Yes @kieran-ryan , this is of course true for all the parsers. I have now changed the base grammar so that it should be fixed in all parsers.

@jacob-wieland-gematik
Copy link
Author

Could you maybe approve re-running of the tests with the latest changes @kieran-ryan ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

No branches or pull requests

2 participants