Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuelang.org: headings inside info blocks have a link icon on hover #3279

Open
jpluscplusm opened this issue Jul 12, 2024 · 1 comment · May be fixed by cue-lang/cuelang.org#485
Open

cuelang.org: headings inside info blocks have a link icon on hover #3279

jpluscplusm opened this issue Jul 12, 2024 · 1 comment · May be fixed by cue-lang/cuelang.org#485
Labels
cuelang.org frontend cuelang.org frontend UI/UX related

Comments

@jpluscplusm
Copy link
Collaborator

What page were you looking at?

https://cuelang.org/docs/introduction/installation/

What version of the site were you looking at?

cue-lang/cuelang.org@1616c6e

What did you do?

I moved my mouse cursor over the "Try out CUE in your browser" header.

What did you expect?

Nothing to change on the page.

What did you see instead?

The standard H1/2/3/4 link icon appeared, to the left of the text, overlapping with the info icon:

image

NB I'm pretty sure this occurs with all the info block variants: info, warning and caution.

@jpluscplusm jpluscplusm added NeedsInvestigation Triage Requires triage/attention cuelang.org frontend cuelang.org frontend UI/UX related labels Jul 12, 2024
@myitcv myitcv removed the Triage Requires triage/attention label Jul 12, 2024
@JorindeUsMedia
Copy link
Collaborator

JorindeUsMedia commented Oct 16, 2024

Todo: Show link icon only for headings in the content itself: not the headings in shortcodes.

Estimate: 30 min - 1 hour

anne-usmedia added a commit to cue-lang/cuelang.org that referenced this issue Dec 18, 2024
* Moved css to only show the anchor hover state on
direct descendents of article__content, so the
anchor does not show inside a shortcode
* Set behaviour of cursor so it does not show the
pointer when we do not show the anchor

To test:
* Go to /examples/shortcodes/info and check if
the anchor icon does not show on hover on the
shortcode titles
* Also check other shortcodes for the same
behaviour

Closes cue-lang/cue#3279

Signed-off-by: Anne van Gorkom <[email protected]>
anne-usmedia added a commit to cue-lang/cuelang.org that referenced this issue Dec 18, 2024
* Moved css to only show the anchor hover state on
direct descendents of article__content, so the
anchor does not show inside a shortcode
* Set behaviour of cursor so it does not show the
pointer when we do not show the anchor

To test:
* Go to /examples/shortcodes/info and check if
the anchor icon does not show on hover on the
shortcode titles
* Also check other shortcodes for the same
behaviour

Fixes: cue-lang/cue#3279

Signed-off-by: Anne van Gorkom <[email protected]>
anne-usmedia added a commit to cue-lang/cuelang.org that referenced this issue Dec 18, 2024
* Moved css to only show the anchor hover state on
direct descendents of article__content, so the
anchor does not show inside a shortcode
* Set behaviour of cursor so it does not show the
pointer when we do not show the anchor

To test:
* Go to /examples/shortcodes/info and check if
the anchor icon does not show on hover on the
shortcode titles
* Also check other shortcodes for the same
behaviour

Fixes: cue-lang/cue#3279

Signed-off-by: Anne van Gorkom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuelang.org frontend cuelang.org frontend UI/UX related
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

3 participants