Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard dependency on react-meteor-data #43

Open
davidsavoie1 opened this issue Jan 6, 2020 · 16 comments
Open

Hard dependency on react-meteor-data #43

davidsavoie1 opened this issue Jan 6, 2020 · 16 comments

Comments

@davidsavoie1
Copy link

I'm trying to update react-meteor-data to the latest 2.0.1 version, but it seems that grapher-react has a dependency on an old version (0.2.16) that prevents such an update. Is it possible to lift this limitation? Thanks!

@justbill2020
Copy link

same... not sure what i get updating to react-meteor-data v2.0.1 but i hate seeing those messages when i update meteor 👍

@Isarstyle
Copy link

Isarstyle commented Apr 2, 2020

It looks as if something went wrong on the upload to atmospherejs.com, getting the same issues, even if the github looks fine. Can you take a look into it?

`=> Errors prevented startup:

While selecting package versions:
error: Conflict: Constraint [email protected] is not satisfied by react-meteor-data 2.0.1.
Constraints on package "react-meteor-data":

EDIT: got it to work by manually cloning the repo into my project folder.
https://forums.meteor.com/t/how-to-install-meteor-package-direct-from-github/1693/2

@Giribaldi
Copy link

Giribaldi commented Jun 16, 2020

EDIT: got it to work by manually cloning the repo into my project folder.
https://forums.meteor.com/t/how-to-install-meteor-package-direct-from-github/1693/2

I'm still having the issue, I can't find the packages folder, where did you clone it ? did you also add the packages after cloning it ?

@Isarstyle
Copy link

@Giribaldi there are two steps to get it working.

  1. you add cultofcoders:grapher-react to the meteor packages file
  2. then you clone the grapher-react repository in a packages folder next to the .meteor e.g. PROJECT/packages/grapher-react
    Then start meteor and it should work, have a great day!

@heticeric
Copy link

Hi @theodorDiaconu

Would you mind releasing the update to atmosphere, please ?

@theodorDiaconu
Copy link
Contributor

@heticeric have you guys tried doing something like: "react-meteor-data@=2.0.1". Otherwise @heticeric create a PR for this 👍

@erixtekila
Copy link

Do that mean that this lib is not maintained anymore ?
Thanks for your kind response.

@theodorDiaconu
Copy link
Contributor

theodorDiaconu commented Dec 10, 2020 via email

@erixtekila
Copy link

erixtekila commented Dec 11, 2020

Otherwise create a PR for this 👍

Why would one create a PR on code that is actually running in this repo ?
We only ask your team to publish the last commit to atmosphere registry.

Community should aid maintaining this.

Here is the place for PR, indeed ;)

@webface
Copy link

webface commented Jan 2, 2021

I too am having this bug and cant develop. Is there an official fix?

@justbill2020
Copy link

@theodorDiaconu this is still an issue... nothing solves the issue. the latest commit just isn't published to meteor atmosphere... even after over a year. is this repo no longer maintained and should we all move away from grapher?

@LordA98
Copy link

LordA98 commented May 17, 2021

Any update on this?

Adding grapher-react to packages/ fixes it locally but this solution doesn't resolve issue in my CICD pipeline. Using @=2.1.2 does not work either.

@theodorDiaconu
Copy link
Contributor

@LordA98 aren't there other breaking changes involved? Can you submit a PR?

@erixtekila
Copy link

Please @theodorDiaconu re-read #43 (comment)
Lots of people claims you or your team to publish a fresh copy to atmosphere registry.

@theodorDiaconu
Copy link
Contributor

theodorDiaconu commented May 18, 2021 via email

@erixtekila
Copy link

An option to get rid of all this, is to use hooks instead of withTracker HOC.
See this closed issue #41 for an implementation.

Greetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants