Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Reactive: False Returns Warning about componentWillReceiveProps Rename #46

Open
LordA98 opened this issue Nov 4, 2020 · 0 comments

Comments

@LordA98
Copy link

LordA98 commented Nov 4, 2020

Hi,

I've created a simple query to fetch data from the database. I have just changed it to 'reactive: false' and received this warning:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: StaticQuery(GrapherQuery(SettingsForm))

This is my query:

export default withQuery(() => {
  return userInfo.clone()
}, {reactive: false, single: true})(SettingsForm)

Should I still be using a HOC if I reactivity is false? Or should I be fetching data from the database within a useEffect?

I am using [email protected] with [email protected] and [email protected] / [email protected]+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant