-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconciliaton API - iteration 3 multi-language #13
Comments
Here is the swagger link for artsdata testing with the latest draft version : |
@sahalali The test bench is getting an error. I think this needs to be fixed on the reconciliation server. @AbhishekPAnil Please deploy to culturecreates github pages so it is easier to test. You can deploy to ghpages using |
@saumier The branch culturecreates:enhancement/issue-13 for test bench has been deployed. |
@sahalali @AbhishekPAnil The endpoint error I experienced above is probably because we don't have an SSL certificate on the server, and you both have probably accepted the insecure connection in your browser. However, we should have an SSL certificate if we want others in the W3C reconciliation group to play around and expore the new endpoint. @sahalali Can you please add an SSL certificate? Also, @sahalali Do you have an idea why the test bench is showing "Validations error for reconcilation response |
@AbhishekPAnil I'll open an issue in our culturecreates testbench repo and ask you to merge your work in to our main branch. culturecreates/testbench#4 |
@sahalali While I am away, please continue to work on Iteration 3 to implement the use cases: Reconcile events with dates, Reconcile with additional properties (literals and URIs), Reconcile with external entity URI only (without needing to send a name). You may want to break these out into individual issues for tracking and testing. |
@saumier Proposal:
Reconcile with external entity URI only (without needing to send a name): I couldn't find an API endpoint in the documentation for this, but I added a new endpoint/resource/{id} for reconciliation by id. We should review this path. Your advice on this matter would be greatly appreciated. |
@sahalali I reviewed our doc on this and the use case "Reconcile with external entity URI only (without needing to send a name)" is about using a property like "schema:sameAs" with an ISNI URI or a CMS URI. I was mistaken that it was for the entity URI itself. So there is no question for me to ask the group because it is already clear that we should be able to pass a property "schema:sameAs" and a URI "http://lod.footlight.io/resouce/123" without a "name" and it should reconcile. Do you agree? Regarding using the ID as the name, the reconciliation spec section 4.4 says:
The Wikidata reconciliation service works with both Q16 and http://www.wikidata.org/entity/Q16 to return the corresponding entity as a candidate. I think we should do the same? |
@saumier When reconciling with existing implementations, it is necessary to include the name in order to produce a result. I attempted to use Wikidata for this purpose. Please let me know if I am mistaken. Although the name is not designated as a mandatory field, no result will be generated if the name is included. |
@sahalali Is there still a question here? I am not sure why it is assigned to me. Let me know if it is ready to test. Thx. |
Please review this. |
@sahalali The Reconciliation test bench at culturecreates is not working with this endpoint |
@sahalali After you restarted the database the reconciliation service worked for a little while but then stopped again before I could make the demo. I only did a couple requests so I don't think there was any stress put on the server. Please investigate as to why the server seems to stop working. |
The graph db server looks stable now. Still I will keep an eye on it for few more days. |
@sahalali The Reconciliation test bench at culturecreates is not working with this endpoint I don't think the graphdb is down, but there is a problem connecting the test bench to the API. Maybe something simple like a missing SSL. Please check it out. |
See doc https://docs.google.com/document/d/10eiOqials4PDipSw3zhNYTw_UbE0W0SuUk7nIAbMHxM/edit#heading=h.qbm5wo48afoq
Test on Culture Creates github page:
https://culturecreates.github.io/testbench/#/client/https%3A%2F%2F35.183.160.6%2Freconcile
Tasks
Tasks
The text was updated successfully, but these errors were encountered: